Skip to content

Require a login cookie before showing the auth dialog as signed in #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YodHeVauHe wants to merge 1 commit into
base: prime
Choose a base branch
from
Open

Require a login cookie before showing the auth dialog as signed in #903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions YoutubeDownloader/ViewModels/Dialogs/AuthSetupViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,24 @@ public IReadOnlyList<Cookie>? Cookies
set => _settingsService.LastAuthCookies = value;
}

public bool IsAuthenticated =>
Cookies?.Any() == true
&&
// None of the '__SECURE' cookies should be expired
Cookies
.Where(c => c.Name.StartsWith("__SECURE", StringComparison.OrdinalIgnoreCase))
.All(c => !c.Expired && c.Expires.ToUniversalTime() > DateTime.UtcNow);
public bool IsAuthenticated
{
get
{
if (Cookies is null)
return false;

// Leftover YouTube cookies are not a login session; require a '__SECURE' cookie.
var loginCookies = Cookies.Where(c =>
c.Name.StartsWith("__SECURE", StringComparison.OrdinalIgnoreCase)
);

return loginCookies.Any()
&& loginCookies.All(c =>
!c.Expired && c.Expires.ToUniversalTime() > DateTime.UtcNow
);
}
}

protected override void Dispose(bool disposing)
{
Expand Down