Repository navigation
Require a login cookie before showing the auth dialog as signed in - #903
Open
YodHeVauHe wants to merge 1 commit into
Open
YodHeVauHe wants to merge 1 commit into
YodHeVauHe wants to merge 1 commit into
Conversation
IsAuthenticated treated leftover YouTube cookies as a session because All() is true for an empty __SECURE filter. Require at least one unexpired login cookie. Co-authored-by: ZaSourceCode <YodHeVauHe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #840.
IsAuthenticatedtreated leftover YouTube cookies as a signed-in session becauseAll()is true when the__SECUREfilter is empty. It now requires at least one unexpired__SECUREcookie. Issue 839 is not part of this change.