Repository navigation
Offer a way to say thanks, in the footer and on the repo - #9
Merged
Merged
Conversation
Two links at the right-hand end of the footer: GitHub Sponsors for the project, and Buy Me a Coffee for me. Muted like everything else down there, taking colour only on hover - findable if someone is looking, quiet if they are not. The icons are inline SVG rather than either service's own artwork. They cost no request, they take their colour from the text around them so they follow the light and dark schemes without a second asset, and a monochrome heart and cup sit together at 13px in a way that a full-colour badge next to a line-drawn heart would not. That also keeps the footer honest. The line beside these links promises that nothing here leaves the browser, and hotlinking a third party's CDN would have every visitor announce themselves to it on every page load. Nothing pasted into the site would leak, but it is a needless thing to serve underneath that sentence. The footer had `span:last-child` doing its spacing, which the new span would have taken over; the note is now named and pushed itself. It also wraps now, since there are four things in there and phones exist.
The same two destinations as the footer, on the surface people arrive at from GitHub rather than from the site. Both use GitHub's own platform keys rather than `custom` URLs, so each renders as the service it is instead of an anonymous link. `buy_me_a_coffee` is a supported key in its own right, checked against GitHub's list rather than assumed.
mgravell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two links at the right-hand end of the footer — GitHub Sponsors for the project, Buy Me a Coffee for me — muted like everything else down there, taking colour only on hover.
Inline SVG rather than either service's artwork
The icons are hand-drawn paths, for three reasons:
Checked by rendering, not by hoping: the first draft's steam wisps came out as two specks at 13px and were redrawn.
Also
The footer's spacing was hanging off
span:last-child, which the new span would have silently taken over. The note is named now and pushes itself. The footer also wraps, since there are four things in it and phones exist.And the repo's own Sponsor button
A second commit adds
.github/FUNDING.ymlwith the same two destinations, for people who arrive from GitHub rather than from the site:Both are GitHub's own platform keys rather than
customURLs, so each renders as the service it is instead of an anonymous link.buy_me_a_coffeebeing a supported key in its own right was checked against GitHub's list rather than assumed.