Repository navigation
Conversation
jennyhliu
added
needs review
Very Small
npauzenga
left a comment
npauzenga
left a comment
There was a problem hiding this comment.
Looks great @jennyhliu! Good find! Just had a couple very minor questions.
| - **CUMULUS-5271** | ||
| - Update zod and adding typescript Node dependencies due to Snyk findings/sercurity vulnerabilities | ||
| - **CUMULUS-5734** | ||
| - Updated `@cumulus/cmr-client` `getGranuleConceptMetadata` to throw on non-404 errors. |
There was a problem hiding this comment.
Should also include the follow-redirects version bump?
There was a problem hiding this comment.
Should we include a note here (or elsewhere) to users about the behavior change? It seems like a possibility that they'll see more errors because of this change and that could be alarming. But it's correct. Those errors should have been surfaced previously.
There was a problem hiding this comment.
It's ci audit issue Micah is fixing, and he will include in his PR.
There was a problem hiding this comment.
updated changelog about behavior change.
| "@cumulus/logger": "22.4.2", | ||
| "ajv": "^6.12.3", | ||
| "follow-redirects": "^1.2.4", | ||
| "follow-redirects": "^1.16.1", |
There was a problem hiding this comment.
Was this a vulnerability?
| "public-ip": "^3.0.0", | ||
| "xml2js": "0.5.0", | ||
| "zod": "^3.20.2" | ||
| "zod": "^4.6.6" |
There was a problem hiding this comment.
match zod version in @cumulus/api/package.json
Summary: Summary of changes
Addresses CUMULUS-5734: Cumulus Allows Granule Deletion After Failed CMR Removal
Changes
@cumulus/cmr-clientgetGranuleConceptMetadatato throw on non-404 errors.Unit test for unpublishGranule error case is already covered here
PR Checklist
📝 Note:
For most pull requests, please Squash and merge to maintain a clean and readable commit history.