Repository navigation
Conversation
Signed-off-by: zhgao <13942661420@163.com>
Contributor
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8960
Pregel.clear_cache([])was treated the same asclear_cache(None), wiping every node's cache, because both the sync and async variants usednodes = nodes or self.nodes.keys(), which conflates an explicit empty list with "not given". Per theBaseCachecontract, onlyNonemeans "all nodes"; an explicit empty list should clear nothing.Two-line fix: only fall back to all nodes when
nodes is None.clear_cache(None)behavior is unchanged.Tests: reproduced with the issue's own repro script (before:
clear_cache([])triggered recomputation; after: no-op for[], still clears all forNone); existing cache tests green locally.AI assistance disclosure: prepared with AI assistance; reproduced and verified locally.