This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
fix mesh shader handles not remapped during module composition - #138
Merged
Merged
Conversation
as I suspected the test fails to compile the example mesh shader from wgpu
Zeophlite
approved these changes
Jul 2, 2026
JMS55
reviewed
Jul 2, 2026
| ) | ||
| .unwrap(); | ||
|
|
||
| //println!("{}", wgsl); |
Contributor
Author
There was a problem hiding this comment.
This was in the existing tests that I copied from. Once I applied the fix I uncommented and ran the test to generate the expected shader output. But I can remove. Was just trying to keep things like the other tests.
robtfm
approved these changes
Jul 2, 2026
Collaborator
|
Lgtm, thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey everyone,
I have been messing around with adding mesh shaders to bevy in a local branch. I thought it would be good to start by building an example app in bevy that uses the wgpu mesh shader example from their 28 release. I got all of that put together but the shader fails to compile, which eventually led me to naga oil.
I started by adding a test to compile the example shader from wgpu, and as I suspected it failed to compile. Then I added a fix. I tried to follow the same style as the existing code, but wasn't sure if it would be better to inline the changes or break them out into their own function. For now I have made things explicit as I can in a new function, but I am fine making any needed changes.