This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Emit override-redirected functions in deterministic order - #137
Merged
robtfm merged 1 commit intoJul 4, 2026
Merged
Conversation
`Redirector::into_module` drove emission order by iterating a `HashMap`, so a module that uses a function override composed to byte-different output each run, defeating caches keyed on the generated source. Use an `IndexMap` for stable, deterministic source-arena order.
niltooth
approved these changes
Jul 3, 2026
james7132
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Redirector::into_moduletopologically sorts functions so dependents are emitted before their callers, but it drives the emission order by iterating aHashMap. That order is valid but arbitrary and reseeds every process, so a module that uses a functionoverride(the redirector only runs when an override is present) composes to byte-different output on every run. This breaks gpu-driver shader caching.Fix
Use an
IndexMapso theretain()loop visits functions in the deterministic source-arena order; same-level functions then emit in a stable order. Behaviour is otherwise unchanged, this path is only reachable when a function override exists, andindexmapis already a dependency.