ProgressBarWindow: the bar fills its row (R2026a draws it 2.7 px tall)

[jesshaley]

On R2026a, ndi.gui.component.ProgressBarWindow draws each bar a few pixels tall. Measured on a 1920×1080 screen, one bar:

axes outer    [11 11 511 28]     the grid row: 28 px tall
axes inner    [16 16 501 2.67]   the drawing area: 2.67 px

The cause: in a grid layout, MATLAB places a uiaxes by its outer box and keeps room inside it for tick labels and a title, even hidden ones. The window's code is unchanged since June 2025. Its sizing and drawing lines are the same as in 463b0ba, so the difference comes from the MATLAB release.

Change:

• Each bar's axes now sit in a borderless uipanel that the grid lays out.
• The axes' inner box is placed BarMargin (5) px inside the panel, in pixels (PositionConstraint innerposition). fitBarAxes places it again whenever the panel resizes, and the panel turns AutoResizeChildren off, without which the resize callback never runs.
• The panel takes the grid's background colour.
• removeBar moves and deletes the panel, which it reaches as Axes.Parent.
• The ProgressBars struct is unchanged; Axes and Patch are still there.

Tests:

• Checked by hand on R2024b and R2026a at 175b08a: the bar now looks the same in both, 5 px inside its row as R2024b drew it, and stays so after the window is resized.
• New test: testBarFillsItsRow. It checks the panel, the margin, AutoResizeChildren, and that the panel moves and is deleted on removeBar.
• testRemoveBar and testDockedBarRenders now read the bar's panel (Axes.Parent), not the axes, for its grid row and parent.
• CI has no display, so the visual check is the manual one above.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf

---

Generated by Claude Code

---

Generated by Claude Code

[jesshaley]

The failing checks here are Cloud CI 1, 2 and 3, the NDI Cloud API tests (testCloudApiProdPart). They aren't caused by this PR:

• The same workflow is red on main (0a2cdec), in every nightly scheduled run from 2026-10-02 to 2026-10-06 (runs 36947377537, 37083040616, 37167587089, 37248878338, 37395496772).
• It also fails on an unrelated PR branch (claude/lightsheet-zarr-ndi-viewer-djp5vk).
• This PR touches nothing those tests run: only ProgressBarWindow.m and its test.

I don't know of a fix for the cloud failure yet, so there's nothing to port here. I'm not re-running it, since it fails on main too.

---

Generated by Claude Code

[github-actions]

Test Results

1 555 tests  +1   1 522 ✅ +1   9m 16s ⏱️ + 1m 15s
  223 suites ±0      33 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit aa96851. ± Comparison against base commit d292984.

♻️ This comment has been updated with latest results.

[jesshaley]

The first run's Test Results had 6 failures. Two were caused by this PR, and the push I just made fixes them:

• TestProgressBarWindow/testRemoveBar and TestProgressBarWindowDocked/testDockedBarRenders checked that the bar sits directly in the grid. With this PR it sits in a panel, so both now check the panel instead.

The other four aren't caused by this PR. They're cloud token-expiry tests, and this PR doesn't touch their code:

• IsTokenExpiredTest/expiredTokenReportsExpired
• IsTokenExpiredTest/tokenInsideSkewWindowReportsExpired
• IsTokenExpiredTest/customSkewIsRespected
• TestGEFManager/testAnExpiredTokenIsWorthRenewing

The same four failed on claude/lightsheet-zarr-ndi-viewer-djp5vk on 2026-10-04 (run 37165768218), a branch that passes otherwise. I haven't found their cause and don't know of a fix, so there's nothing to port.

---

Generated by Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 31.63%. Comparing base (d292984) to head (aa96851).

Files with missing lines	Patch %	Lines
src/ndi/+ndi/+gui/+component/ProgressBarWindow.m	94.73%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   31.62%   31.63%   +0.01%     
==========================================
  Files         898      898              
  Lines       46893    46907      +14     
==========================================
+ Hits        14828    14841      +13     
- Misses      32065    32066       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[stevewds]

Sorry I missed that this was for me. Done now