Skip to content

Add dependency instructions for web view - #888

Merged
Tyrrrz merged 1 commit into
primefrom
webview-help
Sep 11, 2026
Merged

Tyrrrz merged 1 commit into
primefrom
webview-help

Conversation

@Tyrrrz

@Tyrrrz Tyrrrz commented Sep 11, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings September 11, 2026 17:21
@Tyrrrz Tyrrrz added the enhancement New feature or request label Sep 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The placeholder may be covered by NativeWebView, leaving dependency instructions invisible when the web view is unavailable.

Pull request overview

Adds localized, platform-specific WebView dependency instructions to the authentication dialog.

Changes:

  • Replaces the generic loading text with a wrapped authentication placeholder.
  • Adds translated dependency guidance across supported languages.
  • Renames the localization property.
File summaries
File Summary
YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml Displays the localized placeholder; it may be covered by NativeWebView, hiding dependency instructions when the web view is unavailable.
YoutubeDownloader/Localization/LocalizationManager.Ukrainian.cs Adds Ukrainian dependency guidance.
YoutubeDownloader/Localization/LocalizationManager.Spanish.cs Adds Spanish dependency guidance.
YoutubeDownloader/Localization/LocalizationManager.Hungarian.cs Adds Hungarian dependency guidance.
YoutubeDownloader/Localization/LocalizationManager.German.cs Adds German dependency guidance.
YoutubeDownloader/Localization/LocalizationManager.French.cs Adds French dependency guidance.
YoutubeDownloader/Localization/LocalizationManager.English.cs Adds English dependency guidance.
YoutubeDownloader/Localization/LocalizationManager.cs Defines the renamed localization property.
YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs Adds Simplified Chinese dependency guidance.
Review details

Suppressed comments (1)

YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml:67

  • The placeholder is rendered before NativeWebView, while both controls are visible under the same !IsAuthenticated condition. Avalonia panels render later children above earlier ones (and native web views are hosted above Avalonia content), so the web view will cover this text even when it has no usable browser surface; users missing the runtime therefore may never see these dependency instructions. Track web-view initialization/failure separately and show the placeholder only on failure (or otherwise place it in a fallback state that is not simultaneously covered by the web view).
                    IsVisible="{Binding !IsAuthenticated}"
                    Text="{Binding LocalizationManager.AuthenticationPlaceholderText}"
                    TextWrapping="Wrap" />
  • Files reviewed: 9/9 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Tyrrrz
Tyrrrz merged commit 5d60ffa into prime Sep 11, 2026
12 checks passed
@Tyrrrz
Tyrrrz deleted the webview-help branch September 11, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants