Repository navigation
Add dependency instructions for web view - #888
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The placeholder may be covered by NativeWebView, leaving dependency instructions invisible when the web view is unavailable.
Pull request overview
Adds localized, platform-specific WebView dependency instructions to the authentication dialog.
Changes:
- Replaces the generic loading text with a wrapped authentication placeholder.
- Adds translated dependency guidance across supported languages.
- Renames the localization property.
File summaries
| File | Summary |
|---|---|
YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml |
Displays the localized placeholder; it may be covered by NativeWebView, hiding dependency instructions when the web view is unavailable. |
YoutubeDownloader/Localization/LocalizationManager.Ukrainian.cs |
Adds Ukrainian dependency guidance. |
YoutubeDownloader/Localization/LocalizationManager.Spanish.cs |
Adds Spanish dependency guidance. |
YoutubeDownloader/Localization/LocalizationManager.Hungarian.cs |
Adds Hungarian dependency guidance. |
YoutubeDownloader/Localization/LocalizationManager.German.cs |
Adds German dependency guidance. |
YoutubeDownloader/Localization/LocalizationManager.French.cs |
Adds French dependency guidance. |
YoutubeDownloader/Localization/LocalizationManager.English.cs |
Adds English dependency guidance. |
YoutubeDownloader/Localization/LocalizationManager.cs |
Defines the renamed localization property. |
YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs |
Adds Simplified Chinese dependency guidance. |
Review details
Suppressed comments (1)
YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml:67
- The placeholder is rendered before
NativeWebView, while both controls are visible under the same!IsAuthenticatedcondition. Avalonia panels render later children above earlier ones (and native web views are hosted above Avalonia content), so the web view will cover this text even when it has no usable browser surface; users missing the runtime therefore may never see these dependency instructions. Track web-view initialization/failure separately and show the placeholder only on failure (or otherwise place it in a fallback state that is not simultaneously covered by the web view).
IsVisible="{Binding !IsAuthenticated}"
Text="{Binding LocalizationManager.AuthenticationPlaceholderText}"
TextWrapping="Wrap" />
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.