Repository navigation
Refactor archunit-maven-test build - #1751
Merged
Merged
Conversation
schulzjo-tng
approved these changes
Oct 9, 2026
hankem
force-pushed
the
refactor-archunit-maven-test-build
branch
from
October 20, 2026 06:24
d9c618f to
3d7e3ce
Compare
Replace the deprecated `task` DSL, eager `tasks.create` calls and `tasks.findAll` wiring with lazy `tasks.register`, keeping the returned `TaskProvider`s in variables and inlining the task names that were previously built as separate string locals. `dependsOn`, `onlyIf`, `finalizedBy` and `mustRunAfter` are now set in `configure` blocks, the aggregate `runMavenTest` depends on the per-config variants via `tasks.named`, and the JDK log line is attached through `tasks.configureEach` instead of eagerly realizing every task during configuration. Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
`allprojects` within `archunit-maven-test` only contains the project itself, so the lookup of release projects for `mustRunAfter` wiring always returned an empty list. The lookup was correct when it was introduced in 7a1cc96, as the code then lived in `build-steps/maven-integration-test/` and was applied from the root project, where `allprojects` spans the whole build. It silently broke when 4779b3a moved the build config verbatim into the `archunit-maven-test` subproject, changing the project context of the script. Use `rootProject.allprojects` to consider the whole build again. Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
hankem
force-pushed
the
refactor-archunit-maven-test-build
branch
2 times, most recently
from
October 20, 2026 07:10
147cee6 to
3686029
Compare
Redirect `executeRules` stdout and stderr into a log file under `verificationResultArchivePath/<config.identifier>/`, keeping the console output limited to the echoed command. Also print the `verifyRules` command and the `cleanUpMavenTest` copy destination for better traceability of the Maven integration test run. Upload the archived `verification-results/` directory as a GitHub Actions artifact on the `integration-test` job, so the logs and surefire XML reports remain available when a Maven integration test fails in CI. Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
hankem
force-pushed
the
refactor-archunit-maven-test-build
branch
from
October 20, 2026 07:21
3686029 to
4e2a44c
Compare
hankem
commented
Oct 20, 2026
…reMavenTest* tasks Drop the comment asserting that `cleanUpMavenTest*` runs even when a task fails, as `finalizedBy` only runs cleanup after a task that actually executes – it is not a build-level `finally` block, and may not be reached if tests fail and the build is interrupted. Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
hankem
force-pushed
the
refactor-archunit-maven-test-build
branch
from
October 21, 2026 06:22
4e2a44c to
cbb6b51
Compare
hankem
enabled auto-merge
October 21, 2026 06:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestResultTest.assertMatchWith, show context of failure