Repository navigation
fix(h5): accept valid zero and negative location coordinates - #19543
Jarvis636431 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthrough
ChangesH5 chooseLocation 坐标处理
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check 标题准确概括了主要变更：H5 chooseLocation支持有效的零坐标和负坐标。标题简洁、明确，并与代码和测试变更一致。Linked Issues check PR 实现了 #19542的编码要求。isValidCoordinates要求纬度为数字且在 [-90, 90]，经度为数字且在 [-180, 180]；比较结果也会排除 NaN 和 Infinity。相同检查用于初始 iframecoord参数和选点结果，因此支持负数、零值和边界值，并拒绝缺失、非有限及越界值。...opts仍保留显式mapOpts.coord覆盖。…Out of Scope Changes check 变更范围与 #19542直接相关。生产代码只调整 H5chooseLocation的坐标校验。新增测试只验证该 API 的坐标、iframe 参数、消息结果、回调、取消和未选点行为。未发现无关的功能或文件变更。Full details: Linked Issues check
-
Explanation
PR 实现了
#19542的编码要求。isValidCoordinates要求纬度为数字且在 [-90, 90]，经度为数字且在 [-180, 180]；比较结果也会排除 NaN 和 Infinity。相同检查用于初始 iframecoord参数和选点结果，因此支持负数、零值和边界值，并拒绝缺失、非有限及越界值。...opts仍保留显式mapOpts.coord覆盖。测试覆盖初始 URL、选点成功与失败、回调、取消和未选点提交。
-
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 ESLint
-
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
packages/taro-h5/__tests__/location/chooseLocation.test.ts
-
ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.
packages/taro-h5/src/api/location/chooseLocation.ts
-
ESLint skipped: the matched ESLint configuration already failed (missing-dependency).
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
我是小兔，绕过经线与纬线，
看零度坐标也能安然通过。
南行西行，地图照常载入，
选中地点，名称地址一并返回。
若坐标越界，我便轻轻摇头。
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19543 +/- ##
==========================================
+ Coverage 55.60% 55.82% +0.21%
==========================================
Files 467 467
Lines 25659 25662 +3
Branches 6416 6440 +24
==========================================
+ Hits 14268 14326 +58
- Misses 9399 9455 +56
+ Partials 1992 1881 -111
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch has not been deployed
1 participant
这个 PR 做了什么？
Fix H5 chooseLocation coordinate validation. Initial coordinates in the southern/western hemisphere were omitted from the map iframe URL, and selecting a point at latitude or longitude 0 incorrectly reported failure.
Use one numeric latitude/longitude range check for both initial coordinates and selected results. Preserve the explicit coord override, cancellation and submitting without a selection.
Adds 27 DOM regression tests covering negative/zero/boundary coordinates, missing and invalid values, map messages, iframe parameters and result callbacks. The original implementation fails 12 cases.
这个 PR 是什么类型？
这个 PR 涉及以下平台：
验证
Closes #19542
Summary by CodeRabbit
修复
coord可覆盖初始坐标生成的查询参数。测试