Fix Sentry setup: init early, add release, drop captureLastError()

captureLastError() sent the request's last PHP error to Sentry even when
it was silenced with @, e.g. the harmless unlink() race when concurrent
requests delete an expired cache file (WHAT-TRAIN-IS-IT-NOW-8R). Sentry's
own handlers already report non-silenced errors, exceptions and fatals.

Initialise Sentry right after the autoloader, as the Sentry docs
recommend, so that errors while fetching Product Details at startup are
reported, and set the release (deployed commit) and environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: pascalchevrel

app/inc/config.php

@@ -34,31 +34,6 @@
 // Autoloading of classes (both /vendor/ and /app/classes)
 require_once INSTALL_ROOT . 'vendor/autoload.php';
 
-// PHP sends no User-Agent at all on stream based requests. Set ours as the
-// default so that anything we didn't route through Utils::httpClient() or
-// Utils::streamContext() is still identifiable by the sites we query.
-ini_set('user_agent', ReleaseInsights\Utils::USER_AGENT);
-
-// Get Firefox Versions from Product Details library, default cache duration
-$firefox_versions = new Data()->getFirefoxVersions();
-
-// Exact version numbers (strings) from product-details
-define('ESR',             $firefox_versions['FIREFOX_ESR']);
-define('ESR_NEXT',        $firefox_versions['FIREFOX_ESR_NEXT']);
-define('ESR115',          $firefox_versions['FIREFOX_ESR115']);
-define('FIREFOX_NIGHTLY', $firefox_versions['FIREFOX_NIGHTLY']);
-define('DEV_EDITION',     $firefox_versions['FIREFOX_DEVEDITION']);
-define('FIREFOX_BETA',    $firefox_versions['LATEST_FIREFOX_RELEASED_DEVEL_VERSION']);
-define('FIREFOX_RELEASE', $firefox_versions['LATEST_FIREFOX_VERSION']);
-
-// Major version numbers (integers), used across the app
-define('NIGHTLY',     (int) FIREFOX_NIGHTLY);
-define('BETA',        (int) FIREFOX_BETA);
-define('RELEASE',     (int) FIREFOX_RELEASE);
-define('NEXT_ESR',    (int) (ESR_NEXT ?: null));
-define('CURRENT_ESR', (int) ESR);
-define('WIN7_ESR',    ESR115 ? (int) ESR115 : null);
-
 // Are we on one of our staging sites
 $http_host = isset($_SERVER['HTTP_HOST']) ? (string) $_SERVER['HTTP_HOST'] : null;
 
@@ -84,17 +59,52 @@
 // Are we in a dev mode where debug is activated and twig templates not cached?
 define('IS_DEV_MODE', getenv('DEV_MODE') === 'true');
 
-// Define a Nonce for inline scripts
-define('NONCE', bin2hex(random_bytes(20)));
-
-// Set up Sentry endpoint, don't send errors while in dev mode
-if (STAGING) {
-    init(['dsn' => 'https://e17dcdc892db4ee08a6937603e407f76@o1069899.ingest.sentry.io/4505243444772864']);
+/*
+    Set up Sentry as early as possible so that errors during startup (such as
+    fetching Product Details below) are reported. Not used on localhost.
+    deployed-version.txt is generated at build time on all our deployments.
+ */
+if (STAGING || PRODUCTION) {
+    $deployed_version = is_file(WEB_ROOT . 'deployed-version.txt')
+        ? trim((string) file_get_contents(WEB_ROOT . 'deployed-version.txt'))
+        : '';
+
+    init([
+        'dsn' => PRODUCTION
+            ? 'https://20bef71984594e16add1d2c69146ad88@o1069899.ingest.sentry.io/4505243430092800'
+            : 'https://e17dcdc892db4ee08a6937603e407f76@o1069899.ingest.sentry.io/4505243444772864',
+        'environment' => PRODUCTION ? 'production' : 'staging',
+        'release'     => preg_match('/^[0-9a-f]{40}$/', $deployed_version) ? $deployed_version : null,
+    ]);
 }
 
-if (PRODUCTION) {
-    init(['dsn' => 'https://20bef71984594e16add1d2c69146ad88@o1069899.ingest.sentry.io/4505243430092800']);
-}
+// PHP sends no User-Agent at all on stream based requests. Set ours as the
+// default so that anything we didn't route through Utils::httpClient() or
+// Utils::streamContext() is still identifiable by the sites we query.
+ini_set('user_agent', ReleaseInsights\Utils::USER_AGENT);
+
+// Get Firefox Versions from Product Details library, default cache duration
+$firefox_versions = new Data()->getFirefoxVersions();
+
+// Exact version numbers (strings) from product-details
+define('ESR',             $firefox_versions['FIREFOX_ESR']);
+define('ESR_NEXT',        $firefox_versions['FIREFOX_ESR_NEXT']);
+define('ESR115',          $firefox_versions['FIREFOX_ESR115']);
+define('FIREFOX_NIGHTLY', $firefox_versions['FIREFOX_NIGHTLY']);
+define('DEV_EDITION',     $firefox_versions['FIREFOX_DEVEDITION']);
+define('FIREFOX_BETA',    $firefox_versions['LATEST_FIREFOX_RELEASED_DEVEL_VERSION']);
+define('FIREFOX_RELEASE', $firefox_versions['LATEST_FIREFOX_VERSION']);
+
+// Major version numbers (integers), used across the app
+define('NIGHTLY',     (int) FIREFOX_NIGHTLY);
+define('BETA',        (int) FIREFOX_BETA);
+define('RELEASE',     (int) FIREFOX_RELEASE);
+define('NEXT_ESR',    (int) (ESR_NEXT ?: null));
+define('CURRENT_ESR', (int) ESR);
+define('WIN7_ESR',    ESR115 ? (int) ESR115 : null);
+
+// Define a Nonce for inline scripts
+define('NONCE', bin2hex(random_bytes(20)));
 
 // Clean up temp variables from global space
-unset($firefox_versions, $http_host);
+unset($firefox_versions, $http_host, $deployed_version);

app/inc/init.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-use function Sentry\captureLastError;
 use Tracy\Debugger;
 
 // This is our production CSP
@@ -32,8 +31,5 @@
 // Dispatch urls. The $url object is defined in router.php
 $url->loadController();
 
-// Send the last error to Sentry
-captureLastError();
-
 // Make sure web request stops here
 exit;