Skip to content

Commit f505aac

Browse files
authored
CI: migrate test-bot images from Ubuntu 22.04 to 24.04 (#880)
* CI: migrate test-bot images from Ubuntu 22.04 to 24.04 Ubuntu 22.04 ships glibc 2.35, which is now below Homebrew's LINUX_GLIBC_CI_VERSION (2.39). This made 'brew doctor' fail during 'brew test-bot --only-setup', breaking every PR before any formula was built. Ubuntu 24.04 ships glibc 2.39, restoring a Tier 1 config. Also rename the log/bottle upload artifacts to match. * CI: use :latest tag for ubuntu24.04 image The homebrew/ubuntu24.04 image has no :master tag (only the frozen 22.04 image does); its floating tag is :latest. Using :master caused 'manifest unknown' on docker pull. * CI: drop deprecated --skip-recursive-dependents flag brew test-bot migrated into Homebrew/brew, where --skip-recursive-dependents is now odeprecated (skipping recursive dependents is the default). With HOMEBREW_DEVELOPER=1 the deprecation is escalated to a hard error, failing --only-formulae immediately.
1 parent d292ca4 commit f505aac

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

‎.github/workflows/tests.yml‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ permissions:
2222
jobs:
2323
tap_syntax:
2424
if: github.repository == 'maxim-belkin/homebrew-xorg'
25-
runs-on: ubuntu-22.04
25+
runs-on: ubuntu-24.04
2626
container:
27-
image: ghcr.io/homebrew/ubuntu22.04:master
27+
image: ghcr.io/homebrew/ubuntu24.04:latest
2828
steps:
2929
- name: Set up Homebrew
3030
id: set-up-homebrew
@@ -37,7 +37,7 @@ jobs:
3737
if: github.event_name == 'pull_request'
3838
runs-on: ubuntu-latest
3939
container:
40-
image: ghcr.io/homebrew/ubuntu22.04:master
40+
image: ghcr.io/homebrew/ubuntu24.04:latest
4141
options: --user=linuxbrew
4242
defaults:
4343
run:
@@ -70,8 +70,7 @@ jobs:
7070
brew test-bot \
7171
--only-formulae \
7272
--tap=maxim-belkin/xorg \
73-
--root-url="https://ghcr.io/v2/maxim-belkin/xorg" \
74-
--skip-recursive-dependents
73+
--root-url="https://ghcr.io/v2/maxim-belkin/xorg"
7574
7675
- name: Failures summary for brew test-bot --only-formulae
7776
if: always()
@@ -103,7 +102,7 @@ jobs:
103102
if: always()
104103
uses: actions/upload-artifact@v7
105104
with:
106-
name: logs-ubuntu-22.04
105+
name: logs-ubuntu-24.04
107106
path: /github/home/.cache/Homebrew/Logs
108107

109108
- name: Delete logs and home
@@ -130,7 +129,7 @@ jobs:
130129
if: always() && steps.bottles.outputs.failures > 0
131130
uses: actions/upload-artifact@v7
132131
with:
133-
name: bottles-ubuntu-22.04
132+
name: bottles-ubuntu-24.04
134133
path: ~/bottles/failed
135134

136135
# Must be run before the `Upload bottles` step so that failed

0 commit comments

Comments
 (0)