Acceptance testing tweaks.

Author: johnbillion

docker-compose.yml

@@ -1,4 +1,6 @@
 include:
   -
-    path: vendor/johnbillion/plugin-infrastructure/tests/docker-compose.yml
+    path:
+      - vendor/johnbillion/plugin-infrastructure/tests/docker-compose.yml
+      - tests/mu-plugins/acceptance.yml
     project_directory: .

tests/acceptance/playwright.config.ts

@@ -10,6 +10,7 @@ export default defineConfig({
 	outputDir: '../test-results',
 	fullyParallel: false,
 	forbidOnly: !!process.env.CI,
+	retries: process.env.CI ? 1 : 0,
 	workers: 1,
 	reporter: 'list',
 	use: {

tests/acceptance/utils/user-switching.ts

@@ -62,7 +62,12 @@ export class UserSwitchingUtils {
 		await this.page.fill( 'input[name="pwd"]', password );
 		await this.page.locator( '#wp-submit' ).click();
 
-		// @todo verify we're logged in (can't use HTTP status code as WP returns 200 even on failed login)
+		// Wait for the redirect to complete before returning, otherwise a subsequent
+		// navigation can race the login request and land without the auth cookie.
+		await this.page.waitForURL( /\/wp-admin\// );
+
+		// WP returns a 200 for a failed login, so assert on the logged-in state instead.
+		await expect( this.page.locator( '#wpadminbar' ) ).toBeVisible();
 	}
 
 	/**

tests/mu-plugins/acceptance.php

@@ -0,0 +1,4 @@
+<?php
+
+// The autofocus timer on wp-login.php races Playwright filling in the login form.
+add_filter( 'enable_login_autofocus', '__return_false' );

tests/mu-plugins/acceptance.yml

@@ -0,0 +1,4 @@
+services:
+  php:
+    volumes:
+      - ./tests/mu-plugins/acceptance.php:/var/www/html/wp-content/mu-plugins/acceptance.php