[terminal-stylist] Terminal Stylist report: Go console output, Lipgloss, and Huh

[github-actions[bot]]

Overview

The Go console-output architecture is generally strong: terminal styling is centralized, stdout/stderr-aware formatters are widely adopted, Lipgloss colors adapt to light/dark backgrounds, and Huh forms share one accessible theme and TTY gate.

The main gaps are a small set of raw error/warning writes, two tree renderers that bypass the console package's TTY/color-profile handling, duplicated manual prompt logic, and several fixed-width reports that do not adapt well to narrow terminals or long values.

Key metrics

Measure	Result
Non-test .go files scanned under pkg/	1,532
Production files (excluding testdata)	1,372
Test-fixture files under testdata	160
Production fmt.Print* / fmt.Fprint* calls	3,453 across 349 files
Direct writes to os.Stderr	2,535
Direct writes to os.Stdout	125
Calls into pkg/console	2,177 across 275 files
Production files importing pkg/console	279
Production files importing Lipgloss v2	12
Production files importing Huh v2	17
Raw ANSI literals	6, confined to 2 console implementation files

Most fmt calls are not style violations: many write generated YAML/scripts or wrap destination-aware console.Format* output. The high raw call count should therefore not be treated as a migration count.

Priority findings

1. Standardize five raw error/warning paths. These bypass semantic prefixes, adaptive styling, and consistent severity formatting:

   • pkg/cli/mcp_inspect_mcp.go:574 and :588
   • pkg/workflow/cache_steps.go:23
   • pkg/workflow/mcp_renderer.go:111
   • pkg/workflow/push_to_pull_request_branch.go:120

   Use console.PrintErrorMessage, console.PrintWarningMessage, or destination-aware console.Format* helpers. This would also remove inconsistent capitalized prefixes such as Error: and Warning:.

2. Make tree rendering pipe-safe. pkg/cli/mcp_inspect.go:205-223 and pkg/cli/status_command.go:437-446 attach styled tree enumerators/items unconditionally, then write the result directly to stderr. Unlike pkg/console, this path does not visibly gate styling on TTY status or degrade through the destination color profile. Build plain trees for non-TTY/accessibility mode, or add a console tree renderer that applies tty.IsStderrTerminal, NO_COLOR, and color-profile degradation consistently.

3. Replace fixed-width report layouts where values are unbounded. pkg/cli/audit_cross_run_render.go:290-399 uses manual spacing and widths such as %-30s and %-45s. Long server names/domains and narrow terminals can break alignment. Prefer console.RenderTable with MaxWidth: console.DefaultTableWidth; it already wraps cells and falls back to a narrow key/value layout.

4. Consolidate the remaining manual selection flow. pkg/cli/run_interactive.go:164-221 duplicates numbered-list prompting and checks stderr TTY without first checking stdin TTY. console.ShowInteractiveList already centralizes stdin/stderr checks, themed Huh selection, and text fallback. Reusing it would align cancellation, accessibility, and non-TTY behavior.

5. Reduce formatter/write boilerplate incrementally. Many locations use fmt.Fprintln(os.Stderr, console.FormatInfoMessage(...)) even though console.PrintInfoMessage and related print helpers exist. This is correct today, but direct helper use would make stream ownership clearer and prevent future destination mismatch. Limit migration to exact one-line equivalents; retain fmt where composing reports or writing generated content.

What is working well

• pkg/styles/theme.go provides one adaptive semantic palette for errors, warnings, success, info, commands, tables, trees, and schedules.
• pkg/console/console.go applies styles only for the relevant TTY and degrades output using the destination environment/color profile.
• pkg/linters/consolestderr/consolestderr.go detects stdout/stderr formatter mismatches and offers suggested fixes.
• pkg/console/table_width.go uses ANSI-aware width calculation, wraps cells, and provides a narrow fallback.
• pkg/console/prompt_form.go is the sole production creator of huh.NewForm; it consistently applies styles.HuhTheme, accessibility mode, context support, and stdin/stderr TTY checks.
• pkg/styles/huh_theme.go uses lipgloss.LightDark and styles focus, errors, options, navigation, buttons, and text input from the shared palette.
• Secret input paths use huh.EchoModePassword; required workflow inputs and profile values use field validation.
• pkg/cli/compile_schedule_calendar.go explicitly gates cell styling on TTY/accessibility and applies color-profile degradation.
• pkg/cli/work_command_tui_view.go responds to terminal dimensions, bounds rendered content, supplies a minimum-size fallback, and uses Bubble Tea's alternate screen.
• Raw ANSI is limited to pkg/console/prompt_form.go and pkg/console/terminal.go, where it performs cursor/screen control unavailable through Lipgloss and is TTY-gated.

Lipgloss usage inventory

Production imports occur in:

• pkg/cli/compile_schedule_calendar.go
• pkg/cli/engine_secrets.go
• pkg/cli/mcp_inspect.go
• pkg/cli/status_command.go
• pkg/cli/work_command_tui_view.go
• pkg/console/banner.go
• pkg/console/console.go
• pkg/console/render.go
• pkg/console/table_width.go
• pkg/logger/logger.go
• pkg/styles/huh_theme.go
• pkg/styles/theme.go

The strongest patterns are the centralized palette, adaptive colors, bounded tables, ANSI-aware width calculations, and responsive TUI layout. The tree renderers are the notable destination-awareness exception.

Huh usage assessment

Huh is used across 17 production files. The scan found 9 input constructors, 11 selects, 2 multi-selects, 8 confirms, and 1 text field, plus shared option/group construction.

All complete forms flow through console.NewForm, so theme and accessible mode are applied consistently. The implementation correctly distinguishes cancellation through huh.ErrUserAborted, masks secrets, and validates required values in the flows that need it.

Recommended UX follow-up:

• Route run_interactive workflow selection through the shared list abstraction.
• Continue using field-level validation for required values rather than validating only after a form closes.
• Keep text fallbacks for accessibility/non-renderable stderr, but require terminal stdin before attempting to read an interactive choice.

Next actions

1. Fix the five raw severity writes.
2. Add a destination-aware tree rendering helper and migrate the two tree call sites.
3. Convert the cross-run audit's tabular sections to bounded console tables.
4. Reuse console.ShowInteractiveList in run_interactive.
5. Add lint coverage for literal Error: / Warning: writes to standard streams if recurrence becomes common.

Analysis note

Serena project activation succeeded, but its Go language server failed to initialize in the analysis environment. The complete scan therefore used Go's parser/AST plus targeted source inspection; no repository files were changed.

References: §38372536185

Generated by 💄 Terminal Stylist · pi · gpt56 · 135.6 AIC · ⌖ 27 AIC · ⊞ 7.4K · ◷

• expires on Oct 14, 2026, 1:04 AM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Terminal Stylist.

A newer discussion is available at Discussion #68645.