Remove legacy_include_path_in_required_reader_nodes feature flag

Summary:
The `path` field on `required` Reader AST nodes has been unused by the runtime for a long time. `ReaderRequiredField.path` is commented "This field is not used any more". `legacy_include_path_in_required_reader_nodes` existed so the field could be removed from generated artifacts gradually. The diffs below roll every www and xplat project to 0%, after which nothing sets the flag. This diff deletes the flag, and the compiler stops emitting `path` on `RequiredField` Reader nodes.

LAND ORDER: land after the www ramp stack (ends at D124273444) and the xplat ramp stack (ends at D124281529). `FeatureFlags` uses `deny_unknown_fields`, so a config that still sets the flag would fail to parse.

OSS: configs that set `legacy_include_path_in_required_reader_nodes` must drop it. The flag has defaulted to disabled, so artifacts don't change for anyone who never set it.

Reviewed By: voideanvalue

Differential Revision: D124284113

fbshipit-source-id: 4dd86be08b7c6b7ddc6cb6b424c8425d7735dc2f

Author: captbaritone

compiler/crates/common/src/feature_flags.rs

@@ -215,14 +215,6 @@ pub struct FeatureFlags {
     #[serde(default)]
     pub disable_deduping_common_structures_in_raw_response_types: FeatureFlag,
 
-    /// The `path` field in `@required` Reader AST nodes is no longer used. But
-    /// removing them in one diff is too large of a change to ship at once.
-    ///
-    /// This flag will allow us to use the rollout FeatureFlag to remove them
-    /// across a number of diffs.
-    #[serde(default)]
-    pub legacy_include_path_in_required_reader_nodes: FeatureFlag,
-
     /// Disallow @required action THROW on semantically nullable fields.
     /// When enabled, this will prevent the use of THROW action on fields
     /// that are semantically nullable (e.g., fields that can legitimately
@@ -337,7 +329,6 @@ impl Default for FeatureFlags {
             disable_deduping_common_structures_in_artifacts: Default::default(),
             dedupe_common_structures_in_raw_response_types: Default::default(),
             disable_deduping_common_structures_in_raw_response_types: Default::default(),
-            legacy_include_path_in_required_reader_nodes: Default::default(),
             disallow_required_action_throw_on_semantically_nullable_fields: Default::default(),
             enable_shadow_resolvers: Default::default(),
             allow_legacy_relay_resolver_tag: Default::default(),

compiler/crates/relay-codegen/src/build_ast.rs

@@ -1320,24 +1320,11 @@ impl<'schema, 'builder, 'config> CodegenBuilder<'schema, 'builder, 'config> {
         required_metadata: &RequiredMetadataDirective,
         primitive: Primitive,
     ) -> Primitive {
-        let mut obj = object! {
+        Primitive::Key(self.object(object! {
             kind: Primitive::String(CODEGEN_CONSTANTS.required_field),
             field: primitive,
             action: Primitive::String(required_metadata.action.into()),
-        };
-
-        if self
-            .project_config
-            .feature_flags
-            .legacy_include_path_in_required_reader_nodes
-            .is_enabled_for(self.definition_source_location.item)
-        {
-            obj.push(ObjectEntry {
-                key: CODEGEN_CONSTANTS.path,
-                value: Primitive::String(required_metadata.path),
-            });
-        }
-        Primitive::Key(self.object(obj))
+        }))
     }
 
     fn build_catch_node(

compiler/crates/relay-compiler/relay-compiler-config-schema.json

@@ -780,13 +780,6 @@
           "type": "boolean",
           "default": false
         },
-        "legacy_include_path_in_required_reader_nodes": {
-          "description": "The `path` field in `@required` Reader AST nodes is no longer used. But\nremoving them in one diff is too large of a change to ship at once.\n\nThis flag will allow us to use the rollout FeatureFlag to remove them\nacross a number of diffs.",
-          "$ref": "#/$defs/FeatureFlag",
-          "default": {
-            "kind": "disabled"
-          }
-        },
         "no_inline": {
           "description": "For now, this also disallows fragments with variable definitions\nThis also makes @module to opt in using @no_inline internally\nNOTE that the presence of a fragment in this list only controls whether a fragment is *allowed* to\nuse @no_inline: whether the fragment is inlined or not depends on whether it actually uses that\ndirective.",
           "$ref": "#/$defs/FeatureFlag",
@@ -1074,9 +1067,6 @@
               "kind": "enabled"
             },
             "enforce_module_name_prefix_for_non_haste": false,
-            "legacy_include_path_in_required_reader_nodes": {
-              "kind": "disabled"
-            },
             "no_inline": {
               "kind": "disabled"
             },