Skip to content

Commit a53a59a

Browse files
committed
always fail examples on error
1 parent 63082d6 commit a53a59a

1 file changed

Lines changed: 28 additions & 28 deletions

File tree

‎.github/workflows/check-releasability.yml‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -332,22 +332,22 @@ jobs:
332332
DEBIAN_FRONTEND=noninteractive sudo apt-get install --no-install-recommends -yq libasound2-dev libudev-dev libxkbcommon-x11-0 libwayland-dev libx264-164 libx264-dev
333333
- name: Document with scrapping example
334334
id: scrape
335-
continue-on-error: true
335+
# continue-on-error: true
336336
run: |
337337
cargo +nightly doc -Zunstable-options -Zrustdoc-scrape-examples --no-deps --all-features
338-
- name: Fail when needed
339-
run: |
340-
if [[ ${{ steps.initial.outputs.initial }} == "false" ]]; then
341-
if [[ "${{ steps.scrape.outcome }}" == "success" ]]; then
342-
echo "Failure expected but succeeded"
343-
exit 2
344-
fi
345-
else
346-
if [[ "${{ steps.scrape.outcome }}" == "failure" ]]; then
347-
echo "Success expected but failed"
348-
exit 1
349-
fi
350-
fi
338+
# - name: Fail when needed
339+
# run: |
340+
# if [[ ${{ steps.initial.outputs.initial }} == "false" ]]; then
341+
# if [[ "${{ steps.scrape.outcome }}" == "success" ]]; then
342+
# echo "Failure expected but succeeded"
343+
# exit 2
344+
# fi
345+
# else
346+
# if [[ "${{ steps.scrape.outcome }}" == "failure" ]]; then
347+
# echo "Success expected but failed"
348+
# exit 1
349+
# fi
350+
# fi
351351

352352
example-doc-check2:
353353
name: Example Documentation
@@ -388,22 +388,22 @@ jobs:
388388
DEBIAN_FRONTEND=noninteractive sudo apt-get install --no-install-recommends -yq libasound2-dev libudev-dev libxkbcommon-x11-0 libwayland-dev libx264-164 libx264-dev
389389
- name: Document with scrapping example
390390
id: scrape
391-
continue-on-error: true
391+
# continue-on-error: true
392392
run: |
393393
cargo +nightly doc -Zunstable-options -Zrustdoc-scrape-examples --no-deps --all-features
394-
- name: Fail when needed
395-
run: |
396-
if [[ ${{ steps.initial.outputs.initial }} == "false" ]]; then
397-
if [[ "${{ steps.scrape.outcome }}" == "success" ]]; then
398-
echo "Failure expected but succeeded"
399-
exit 2
400-
fi
401-
else
402-
if [[ "${{ steps.scrape.outcome }}" == "failure" ]]; then
403-
echo "Success expected but failed"
404-
exit 1
405-
fi
406-
fi
394+
# - name: Fail when needed
395+
# run: |
396+
# if [[ ${{ steps.initial.outputs.initial }} == "false" ]]; then
397+
# if [[ "${{ steps.scrape.outcome }}" == "success" ]]; then
398+
# echo "Failure expected but succeeded"
399+
# exit 2
400+
# fi
401+
# else
402+
# if [[ "${{ steps.scrape.outcome }}" == "failure" ]]; then
403+
# echo "Success expected but failed"
404+
# exit 1
405+
# fi
406+
# fi
407407

408408
release-private-registry:
409409
name: Release to Private Registry

0 commit comments

Comments
 (0)