reduce LLM verbosity

Author: Xetera

Dockerfile

@@ -7,7 +7,6 @@ RUN CGO_ENABLED=0 go build -trimpath -ldflags="-s -w" -o /c4gateway ./cmd/c4gate
 
 FROM alpine:3.20
 COPY --from=build /c4gateway /usr/local/bin/c4gateway
-# Game files players download after registering (-patch-dir).
 COPY patched/ /patched/
 ENV C4GW_PATCH_DIR=/patched
 # for -capture; a volume mounted here starts out owned by nobody

docker-compose.yml

@@ -52,4 +52,4 @@ services:
       C4GW_RAW_DUMP: "/logs/raw"
     volumes:
       - ./logs:/logs
-      - ./patched:/patched:ro   # game files players download after registering
+      - ./patched:/patched:ro

gateway/cmd/c4assets/main.go

@@ -200,7 +200,6 @@ func run(data, out string) error {
 		return fmt.Errorf("online menu art: %w", err)
 	}
 
-	// Online scenarios are the .sco files.
 	scos, err := filepath.Glob(filepath.Join(data, "Scenarios", "*.sco"))
 	if err != nil {
 		return err
@@ -271,7 +270,6 @@ func run(data, out string) error {
 	return nil
 }
 
-// Slug must match web.slug: lowercase, spaces to hyphens.
 func Slug(name string) string {
 	return strings.ReplaceAll(strings.ToLower(name), " ", "-")
 }

gateway/internal/gateway/admin.go

@@ -8,9 +8,8 @@ import (
 
 // AdminHandler serves read-only debug endpoints. Bind it to localhost.
 //
-//	/debug/stats     command and route counters, open questions, unmatched statements
+//	/debug/stats     command and route counters, unmatched statements
 //	/debug/unmatched  just the unmatched statements
-//	/debug/questions  just the open-question hits
 //	/debug/sessions   connected clients
 //	/debug/routes     every accepted statement shape
 func (g *Gateway) AdminHandler() http.Handler {
@@ -36,9 +35,6 @@ func (g *Gateway) AdminHandler() http.Handler {
 	mux.HandleFunc("/debug/unmatched", func(w http.ResponseWriter, r *http.Request) {
 		writeJSON(w, g.rec.Snapshot()["unmatched"])
 	})
-	mux.HandleFunc("/debug/questions", func(w http.ResponseWriter, r *http.Request) {
-		writeJSON(w, g.rec.Snapshot()["open_questions"])
-	})
 	mux.HandleFunc("/debug/sessions", func(w http.ResponseWriter, r *http.Request) {
 		sessions := g.Sessions()
 		sort.Slice(sessions, func(i, j int) bool { return sessions[i].ID < sessions[j].ID })
@@ -49,11 +45,10 @@ func (g *Gateway) AdminHandler() http.Handler {
 			Name     string `json:"name"`
 			Template string `json:"template,omitempty"`
 			Regexp   string `json:"regexp"`
-			Question string `json:"open_question,omitempty"`
 		}
 		out := make([]info, len(g.routes))
 		for i, rt := range g.routes {
-			out[i] = info{rt.name, rt.tmpl, rt.re.String(), rt.question}
+			out[i] = info{rt.name, rt.tmpl, rt.re.String()}
 		}
 		writeJSON(w, out)
 	})

gateway/internal/gateway/driver.go

@@ -212,8 +212,6 @@ func hLiteralSelect(ctx context.Context, c *call) (*result, error) {
 	return c.queryCols(ctx, cols, c.sql)
 }
 
-// ---- Screenshot blob writes ----
-//
 // The game writes screenshots by editing the recordset returned by
 // ScreenShot/*/GetRecord. How the ODBC driver turns that into SQL is not known
 // yet, so this route accepts the likely shape (UPDATE ... SET screenshot=<blob>
@@ -227,10 +225,9 @@ var andSplitRE = regexp.MustCompile(`(?i)\s+and\s+`)
 
 func blobRoutes() []*route {
 	return []*route{{
-		name:     "ScreenShot/*/blob write (driver generated)",
-		re:       blobUpdateRE,
-		question: "README §10: how the screenshot blob is written; this is a guessed shape, confirm it and the image format",
-		fn:       hBlobWrite,
+		name: "ScreenShot/*/blob write (driver generated)",
+		re:   blobUpdateRE,
+		fn:   hBlobWrite,
 	}}
 }
 

gateway/internal/gateway/handlers.go

@@ -15,7 +15,7 @@ import (
 
 func now32() int64 { return time.Now().Unix() & 0x7fffffff }
 
-// query runs a backend SELECT and converts rows to the given columns. Integer
+// queryCols runs a backend SELECT and converts rows to the given columns. Integer
 // columns are clamped to 32 bits: the game aborts on 64-bit values.
 func (c *call) queryCols(ctx context.Context, cols []Column, q string, args ...any) (*result, error) {
 	rs, err := c.g.db.QueryContext(ctx, q, args...)
@@ -93,8 +93,6 @@ func (c *call) backendErr(err error) error {
 func (c *call) uid() int64  { return int64(c.s.acct.UserID) }
 func (c *call) c4id() int64 { return int64(c.s.acct.C4ID) }
 
-// ---- Login ----
-
 func hStatus(ctx context.Context, c *call) (*result, error) {
 	res, err := c.query(ctx, "SELECT version, status, message FROM c4_status LIMIT 1")
 	if err != nil {
@@ -164,8 +162,6 @@ func hChecksums(ctx context.Context, c *call) (*result, error) {
 	return res, err
 }
 
-// ---- Scenario lists ----
-
 func hEmpireScenarios(ctx context.Context, c *call) (*result, error) {
 	return c.query(ctx, "SELECT scenario, scenid FROM c4_scenarios WHERE empire='1' ORDER BY scenario")
 }
@@ -213,8 +209,6 @@ func hTimeTrialGoals(ctx context.Context, c *call) (*result, error) {
 		c.int(0), c.int(1))
 }
 
-// ---- Single scenario ----
-
 func hScenarioID(ctx context.Context, c *call) (*result, error) {
 	return c.query(ctx, "SELECT scenid FROM c4_scenarios WHERE scenario=?", c.str(0))
 }
@@ -231,8 +225,6 @@ func hScenarioChecksum(ctx context.Context, c *call) (*result, error) {
 	return res, err
 }
 
-// ---- Seasons ----
-
 func hSeasonID(ctx context.Context, c *call) (*result, error) {
 	return c.query(ctx, "SELECT seasonid FROM c4_comp_seasons WHERE activedate < ? ORDER BY seasonid DESC LIMIT 1", now32())
 }
@@ -248,8 +240,6 @@ func hNextSeason(ctx context.Context, c *call) (*result, error) {
 	return res, nil
 }
 
-// ---- Rankings ----
-
 func hArenaHasRank(ctx context.Context, c *call) (*result, error) {
 	return c.query(ctx, "SELECT COUNT(1) FROM c4_comp_rankings WHERE seasonid=? AND scenid=? AND userid=?", c.int(0), c.int(1), c.uid())
 }
@@ -342,8 +332,6 @@ func hEmpireLeaderboard(ctx context.Context, c *call) (*result, error) {
 	return c.leaderboard(ctx, "c4_map_cities", "r.scenid=?", []any{c.int(0)}, 1)
 }
 
-// ---- Uploads ----
-
 // checkUpload flags stat values and targets that look wrong. Ranges are
 // guesses, so by default problems are only logged; -enforce-uploads rejects.
 func (c *call) checkUpload(ctx context.Context, arena bool, seasonid, scenid int64, stats []Value) error {
@@ -455,8 +443,6 @@ func hEmpireUpdateRank(ctx context.Context, c *call) (*result, error) {
 		WHERE scenid=? AND userid=?`, args...)
 }
 
-// ---- Screenshots ----
-
 func hArenaSSCount(ctx context.Context, c *call) (*result, error) {
 	return c.query(ctx, "SELECT COUNT(1) FROM c4_comp_ss WHERE seasonid=? AND scenid=? AND userid=?", c.int(0), c.int(1), c.uid())
 }
@@ -489,8 +475,6 @@ func hEmpireSSGet(ctx context.Context, c *call) (*result, error) {
 	return c.query(ctx, "SELECT scenid, userid, screenshot FROM c4_map_ss WHERE scenid=? AND userid=?", c.int(0), c.uid())
 }
 
-// ---- Building lists ----
-
 func hArenaBuildingsCount(ctx context.Context, c *call) (*result, error) {
 	return c.query(ctx, "SELECT COUNT(1) FROM c4_comp_buildings WHERE seasonid=? AND scenid=? AND userid=?", c.int(0), c.int(1), c.uid())
 }
@@ -530,8 +514,6 @@ func hEmpireBuildingsUpdate(ctx context.Context, c *call) (*result, error) {
 	return c.exec(ctx, "UPDATE c4_map_buildings SET buildings=? WHERE scenid=? AND userid=?", c.str(0), c.int(1), c.uid())
 }
 
-// ---- End of game ----
-
 func hEmpireEndgame(ctx context.Context, c *call) (*result, error) {
 	return c.query(ctx, "SELECT favor, timeplayed, population, happiness, funds, treasury, culture, security, prosperity FROM c4_map_cities WHERE scenid=? AND userid=?",
 		c.int(0), c.uid())

gateway/internal/gateway/recorder.go

@@ -19,8 +19,7 @@ import (
 )
 
 // Recorder is the logging and investigation layer. Everything the gateway
-// sees goes to a JSON-lines capture file; statements nothing understands, and
-// hits on routes tied to open reverse-engineering questions, are also kept in
+// sees goes to a JSON-lines capture file; statements nothing understands are also kept in
 // memory for the admin endpoint.
 type Recorder struct {
 	Log     *slog.Logger
@@ -32,7 +31,6 @@ type Recorder struct {
 	mu        sync.Mutex
 	commands  map[string]int64
 	routes    map[string]int64
-	questions map[string]*questionEntry
 	unmatched map[string]*unmatchedEntry
 }
 
@@ -54,22 +52,13 @@ type unmatchedEntry struct {
 	Users       map[string]int64 `json:"users"`
 }
 
-type questionEntry struct {
-	Route    string    `json:"route"`
-	Question string    `json:"question"`
-	Count    int64     `json:"count"`
-	LastSeen time.Time `json:"last_seen"`
-	Example  string    `json:"example"`
-}
-
 func NewRecorder(o RecorderOptions) (*Recorder, error) {
 	r := &Recorder{
 		sqlMax:    o.SQLMax,
 		rawDir:    o.RawDir,
 		started:   time.Now(),
 		commands:  map[string]int64{},
 		routes:    map[string]int64{},
-		questions: map[string]*questionEntry{},
 		unmatched: map[string]*unmatchedEntry{},
 	}
 	handlers := multiHandler{slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: o.ConsoleLevel})}
@@ -115,21 +104,6 @@ func (r *Recorder) countRoute(name string) {
 	r.mu.Unlock()
 }
 
-// question records a hit on a route whose behaviour is not fully understood.
-func (r *Recorder) question(s *Session, rt *route, sql string) {
-	r.mu.Lock()
-	q := r.questions[rt.name]
-	if q == nil {
-		q = &questionEntry{Route: rt.name, Question: rt.question}
-		r.questions[rt.name] = q
-	}
-	q.Count++
-	q.LastSeen = time.Now()
-	q.Example = r.SQL(sql)
-	r.mu.Unlock()
-	s.log.Warn("open question: route hit", "event", "open_question", "route", rt.name, "question", rt.question, "sql", r.SQL(sql))
-}
-
 func (r *Recorder) recordUnmatched(s *Session, command, norm string, params []mysqlproto.Value) {
 	fp := fingerprint(norm)
 	ps := summarizeParams(params)
@@ -164,16 +138,10 @@ func (r *Recorder) Snapshot() map[string]any {
 		unmatched = append(unmatched, c)
 	}
 	sort.Slice(unmatched, func(i, j int) bool { return unmatched[i].Count > unmatched[j].Count })
-	questions := make([]questionEntry, 0, len(r.questions))
-	for _, q := range r.questions {
-		questions = append(questions, *q)
-	}
-	sort.Slice(questions, func(i, j int) bool { return questions[i].Route < questions[j].Route })
 	return map[string]any{
 		"uptime_seconds": int(time.Since(r.started).Seconds()),
 		"commands":       copyCounts(r.commands),
 		"routes":         copyCounts(r.routes),
-		"open_questions": questions,
 		"unmatched":      unmatched,
 	}
 }